Add formatter for int -> string #4541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a formatter for converting from int to string. Using this formatter fixes a bug with SnapshotShardFailure that models ShardId as a string instead of an int. Fixes #4537
codebrain
approved these changes
Apr 2, 2020
Mpdreamz
approved these changes
Apr 3, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2020
This commit adds a formatter for converting from int to string. Using this formatter fixes a bug with SnapshotShardFailure that models ShardId as a string instead of an int. Fixes #4537
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2020
This commit adds a formatter for converting from int to string. Using this formatter fixes a bug with SnapshotShardFailure that models ShardId as a string instead of an int. Fixes #4537
russcam
added a commit
that referenced
this pull request
Apr 3, 2020
russcam
added a commit
that referenced
this pull request
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a formatter for converting from
int to string. Using this formatter fixes a bug
with SnapshotShardFailure that models ShardId as
a string instead of an int.
Fixes #4537