Fix Node Info #4544
Merged
Fix Node Info #4544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperties to NodeInfo. Fixes broken integration test against 7.7.0-SNAPSHOT
codebrain
changed the title
russcam
approved these changes
Apr 3, 2020
| [DataMember(Name = "process")] | ||
| public NodeProcessInfo Process { get; internal set; } | ||
| [DataMember(Name = "total_indexing_buffer")] | ||
| public long TotalIndexingBuffer { get; internal set; } |
There was a problem hiding this comment.
is this a new property in 7.7.0? I think we should add an XML comment to say which versions it's relevant to, if not relevant for all 7.x versions.
There was a problem hiding this comment.
Not sure, I will make it nullable.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2020
This commit adds some missing roles to NodeRole and some additional properties to NodeInfo.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2020
This commit adds some missing roles to NodeRole and some additional properties to NodeInfo.
codebrain
added a commit
that referenced
this pull request
Apr 3, 2020
codebrain
added a commit
that referenced
this pull request
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some missing roles to NodeRole and some additional properties to NodeInfo.
Fixes broken integration test against 7.7.0-SNAPSHOT