Fixes integration tests against latest 7.7.0-SNAPSHOT #4545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperties to NodeInfo. Fixes broken integration test against 7.7.0-SNAPSHOT
- Change date histogram aggregations to use minimum document = 0 in order to pass server validation. - Changes terms query to use a string value to pass server validation - Change search template API test to not tie to a specific server message substring
russcam
approved these changes
Apr 3, 2020
| else | ||
| response.ServerError.Error.Reason.Should().Contain("unknown query [atch]"); | ||
| } | ||
| protected override void ExpectResponse(ISearchResponse<Project> response) => response.ServerError.Should().NotBeNull(); |
There was a problem hiding this comment.
maybe
response.ServerError.Error.Reason.Should().Contain("query");for both? It would provide a slightly stronger assertion for why there is an error
There was a problem hiding this comment.
I was just conscious that binding the test to the error message probably isn't a good idea as the error message can change.
There was a problem hiding this comment.
it's a fair point, historically verifiable! Is there some other way we can assert that the error is related to what we expect it to be?
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-master master
# Navigate to the new working tree
cd .worktrees/backport-master
# Create a new branch
git switch --create backport-4545-to-master
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 2a73a4e26fc731442d02650eeb2b77566a6450c4
# Push it to GitHub
git push --set-upstream origin backport-4545-to-master
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-masterThen, create a pull request where the |
codebrain
added a commit
that referenced
this pull request
Apr 3, 2020
- Change date histogram aggregations to use minimum document = 0 in order to pass server validation. - Changes terms query to use a string value to pass server validation - Change search template API test to not tie to a specific server message substring Fixes #4521 Fixes #4508 Co-authored-by: Stuart Cam <stuart.cam@elastic.co>
russcam
pushed a commit
that referenced
this pull request
Apr 15, 2020
- Change date histogram aggregations to use minimum document = 0 in order to pass server validation. - Changes terms query to use a string value to pass server validation - Change search template API test to not tie to a specific server message substring Fixes #4521 Fixes #4508 (cherry picked from commit 2a73a4e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4521
Fixes #4508