Skip to content

Implement ConstantKeyword property #4593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Implement ConstantKeyword property #4593

merged 2 commits into from
Apr 17, 2020

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Apr 15, 2020

Relates: elastic/elasticsearch#49713

This commit adds the ConstantKeyword property to the client.
Value is exposed as type Object as it can be a string or numeric
value.

Relates: elastic/elasticsearch#49713

This commit adds the ConstantKeyword property to the client.
Value is exposed as type Object as it can be a string or numeric
value.
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than two nitpicks around spacing.

@russcam russcam merged commit 38edce2 into master Apr 17, 2020
@russcam russcam deleted the feature/constant-keyword branch April 17, 2020 05:25
@github-actions
Copy link
Contributor

The backport to 7.7 failed:

The process 'git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.7 7.7
# Navigate to the new working tree
cd .worktrees/backport-7.7
# Create a new branch
git switch --create backport-4593-to-7.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 38edce2c6553cfac448efaed95b3b0d0fcc7f2f9
# Push it to GitHub
git push --set-upstream origin backport-4593-to-7.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.7

Then, create a pull request where the base branch is 7.7 and the compare/head branch is backport-4593-to-7.7.

@github-actions
Copy link
Contributor

The backport to 7.x failed:

The process 'git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.x 7.x
# Navigate to the new working tree
cd .worktrees/backport-7.x
# Create a new branch
git switch --create backport-4593-to-7.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 38edce2c6553cfac448efaed95b3b0d0fcc7f2f9
# Push it to GitHub
git push --set-upstream origin backport-4593-to-7.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.x

Then, create a pull request where the base branch is 7.x and the compare/head branch is backport-4593-to-7.x.

russcam added a commit that referenced this pull request Apr 17, 2020
Implement ConstantKeyword property

(cherry picked from commit 38edce2)
russcam added a commit that referenced this pull request Apr 17, 2020
Implement ConstantKeyword property

(cherry picked from commit 38edce2)
@russcam
Copy link
Contributor Author

russcam commented Apr 17, 2020

manually backported to 7.7 and 7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants