Fix api url lookups #4714
Merged
Fix api url lookups #4714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in the ApiUrlsLookup generator to use the endpoint filename when comparing against the list of high level APIs to ignore.
This commit fixes a bug in the CSharp method name generation where Index is removed from the name of the SimulateIndexTemplate method in the Indices namespace. Removing this causes a collision with SimulateTemplate
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.7 7.7
# Navigate to the new working tree
cd .worktrees/backport-7.7
# Create a new branch
git switch --create backport-4714-to-7.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick d36aabbd999ce0029d530c368839217fc939d0d7
# Push it to GitHub
git push --set-upstream origin backport-4714-to-7.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.7Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-master master
# Navigate to the new working tree
cd .worktrees/backport-master
# Create a new branch
git switch --create backport-4714-to-master
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick d36aabbd999ce0029d530c368839217fc939d0d7
# Push it to GitHub
git push --set-upstream origin backport-4714-to-master
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-masterThen, create a pull request where the |
russcam
added a commit
that referenced
this pull request
May 27, 2020
* Exclude lookups for ignored high level APIs This commit fixes a bug in the ApiUrlsLookup generator to use the endpoint filename when comparing against the list of high level APIs to ignore. * Do not remove Index from SimulateIndexTemplate method name This commit fixes a bug in the CSharp method name generation where Index is removed from the name of the SimulateIndexTemplate method in the Indices namespace. Removing this causes a collision with SimulateTemplate (cherry picked from commit d36aabb)
russcam
added a commit
that referenced
this pull request
May 27, 2020
* Exclude lookups for ignored high level APIs This commit fixes a bug in the ApiUrlsLookup generator to use the endpoint filename when comparing against the list of high level APIs to ignore. * Do not remove Index from SimulateIndexTemplate method name This commit fixes a bug in the CSharp method name generation where Index is removed from the name of the SimulateIndexTemplate method in the Indices namespace. Removing this causes a collision with SimulateTemplate (cherry picked from commit d36aabb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of bugs in the ApiUrlsLookup generator:
of high level APIs to ignore.
where Index is removed from the name of the SimulateIndexTemplate
method in the Indices namespace. Removing this causes a collision
with SimulateTemplate