Skip to content

Update getting-started.asciidoc #4730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 3, 2020
Merged

Update getting-started.asciidoc #4730

merged 4 commits into from
Jun 3, 2020

Conversation

doggy8088
Copy link
Contributor

Bug code fixed

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Jun 2, 2020 •
edited
Loading

💚 CLA has been signed

@doggy8088
Copy link
Contributor Author

@cla-checker-service just signed.

@russcam
Copy link
Contributor

russcam commented Jun 2, 2020

@doggy8088 thanks for the PR. Could you please update https://github.com/elastic/elasticsearch-net/blob/7.x/tests/Tests/ClientConcepts/LowLevel/GettingStarted.doc.cs, the file from which the asciidoc is generated? Thanks!

@doggy8088
Copy link
Contributor Author

@russcam Yes, already done.

@doggy8088
Copy link
Contributor Author

@russcam Should I remove the commit for docs/client-concepts/low-level/getting-started.asciidoc ?

@russcam
Copy link
Contributor

russcam commented Jun 3, 2020

Ideally, docs/client-concepts/low-level/getting-started.asciidoc is committed too, which can be generated from a change to https://github.com/elastic/elasticsearch-net/blob/7.x/tests/Tests/ClientConcepts/LowLevel/GettingStarted.doc.cs by running

./build documentation

from the root of the solution

russcam
russcam approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of really small formatting changes, otherwise LGTM, thanks @doggy8088

doggy8088 and others added 2 commits June 3, 2020 13:10
@doggy8088 @russcam
Update tests/Tests/ClientConcepts/LowLevel/GettingStarted.doc.cs
944529c 
Co-authored-by: Russ Cam <russ.cam@elastic.co>
@doggy8088 @russcam
Update docs/client-concepts/low-level/getting-started.asciidoc
51a6f1f 
Co-authored-by: Russ Cam <russ.cam@elastic.co>
@russcam russcam merged commit e26de7b into elastic:7.x Jun 3, 2020
russcam added a commit that referenced this pull request Jun 3, 2020
@doggy8088 @russcam
Update getting-started.asciidoc (#4730)
78c1a76 
This commit updates the low level client search example
in the getting started docs.

Co-authored-by: Russ Cam <russ.cam@elastic.co>
(cherry picked from commit e26de7b)
russcam added a commit that referenced this pull request Jun 3, 2020
@doggy8088 @russcam
Update getting-started.asciidoc (#4730)
76bc611 
This commit updates the low level client search example
in the getting started docs.

Co-authored-by: Russ Cam <russ.cam@elastic.co>
(cherry picked from commit e26de7b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@russcam russcam russcam approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doggy8088 @elasticmachine @russcam