Skip to content

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jun 10, 2020

…egationSource

This commit adds FixedInterval and CalendarInterval to
IDateHistogramCompositeAggregationSource and deprecates
Interval.

FixedInterval uses Time type as units must be specified and the largest unit
supported is Day.

CalendarInterval can specify either a DateInterval or a DateMathTime
with a fixed unit of 1.

Closes #4695.

…egationSource

This commit adds FixedInterval and CalendarInterval to
IDateHistogramCompositeAggregationSource and deprecates
Interval.

FixedInterval uses Time type as units must be specified and the largest unit
supported is Day.

CalendarInterval can specify either a DateInterval or a DateMathTime
with a fixed unit of 1.

Closes #4695.
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@russcam
Copy link
Contributor Author

russcam commented Jun 17, 2020

opened #4781 for the Date property tests

@russcam russcam merged commit e324c91 into master Jun 17, 2020
@russcam russcam deleted the feature/4695 branch June 17, 2020 00:16
github-actions bot pushed a commit that referenced this pull request Jun 17, 2020
…egationSource (#4772)

This commit adds FixedInterval and CalendarInterval to
IDateHistogramCompositeAggregationSource and deprecates
Interval.

FixedInterval uses Time type as units must be specified and the largest unit
supported is Day.

CalendarInterval can specify either a DateInterval or a DateMathTime
with a fixed unit of 1.

Closes #4695.
github-actions bot pushed a commit that referenced this pull request Jun 17, 2020
…egationSource (#4772)

This commit adds FixedInterval and CalendarInterval to
IDateHistogramCompositeAggregationSource and deprecates
Interval.

FixedInterval uses Time type as units must be specified and the largest unit
supported is Day.

CalendarInterval can specify either a DateInterval or a DateMathTime
with a fixed unit of 1.

Closes #4695.
russcam added a commit that referenced this pull request Jun 17, 2020
…egationSource (#4772) (#4783)

This commit adds FixedInterval and CalendarInterval to
IDateHistogramCompositeAggregationSource and deprecates
Interval.

FixedInterval uses Time type as units must be specified and the largest unit
supported is Day.

CalendarInterval can specify either a DateInterval or a DateMathTime
with a fixed unit of 1.

Closes #4695.

Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam added a commit that referenced this pull request Jun 17, 2020
…egationSource (#4772) (#4782)

This commit adds FixedInterval and CalendarInterval to
IDateHistogramCompositeAggregationSource and deprecates
Interval.

FixedInterval uses Time type as units must be specified and the largest unit
supported is Day.

CalendarInterval can specify either a DateInterval or a DateMathTime
with a fixed unit of 1.

Closes #4695.

Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nest DateHistogramCompositeAggregationSource does not have CalendarInterval and FixedInterval
2 participants