Ignore ContainsMetadata field when automapping Attachment #4789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds [Ignore] attribute to the ContainsMetadata field to ignore the field when automapping an Attachment. [IgnoreDataMember] ignores the value when serializing an instance of Attachment, but NoopPropertyVisitor does not take into account [IgnoreDataMember] when mapping properties.
|
Opened #4781 for failing tests. Merging this in |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 18, 2020
This commit adds [Ignore] attribute to the ContainsMetadata field to ignore the field when automapping an Attachment. [IgnoreDataMember] ignores the value when serializing an instance of Attachment, but NoopPropertyVisitor does not take into account [IgnoreDataMember] when mapping properties.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 18, 2020
This commit adds [Ignore] attribute to the ContainsMetadata field to ignore the field when automapping an Attachment. [IgnoreDataMember] ignores the value when serializing an instance of Attachment, but NoopPropertyVisitor does not take into account [IgnoreDataMember] when mapping properties.
russcam
added a commit
that referenced
this pull request
Jun 18, 2020
) This commit adds [Ignore] attribute to the ContainsMetadata field to ignore the field when automapping an Attachment. [IgnoreDataMember] ignores the value when serializing an instance of Attachment, but NoopPropertyVisitor does not take into account [IgnoreDataMember] when mapping properties. Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam
added a commit
that referenced
this pull request
Jun 18, 2020
) This commit adds [Ignore] attribute to the ContainsMetadata field to ignore the field when automapping an Attachment. [IgnoreDataMember] ignores the value when serializing an instance of Attachment, but NoopPropertyVisitor does not take into account [IgnoreDataMember] when mapping properties. Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
[Ignore]attribute to theContainsMetadatafield to ignore the field when automapping an Attachment.
[IgnoreDataMember]ignores the value when serializing aninstance of Attachment, but
NoopPropertyVisitordoes nottake into account
[IgnoreDataMember]when mapping properties.