Skip to content

Remove duplicated properties #4793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Remove duplicated properties #4793

merged 1 commit into from
Jun 30, 2020

Conversation

DanAtkinson
Copy link
Contributor

@DanAtkinson DanAtkinson commented Jun 18, 2020

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@russcam
Copy link
Contributor

russcam commented Jun 23, 2020

Thanks for opening @DanAtkinson. This change is probably better handled in the DocsGenerator, to deduplicate the overloaded methods when generating the asciidoc labelled list. Would you like to tackle this? I think it would just need a change in

foreach (var item in visitor.LabeledListItems.OrderBy(l => l.Label)) labeledList.Items.Add(item);

to distinct by Label too.

@DanAtkinson
Copy link
Contributor Author

@russcam Thanks. I'll take a look. I haven't used the DocsGenerator but it should be fairly straightforward to run, change, test, and verify.

@russcam
Copy link
Contributor

russcam commented Jun 24, 2020

Doc generation can be run from the build script in the root of the repository

.\build documentation

@russcam russcam merged commit 7609ad8 into elastic:master Jun 30, 2020
@russcam
Copy link
Contributor

russcam commented Jun 30, 2020

Hi @DanAtkinson, I went ahead and made the change to GeneratedAsciidocVisitor, and merged this in. Thanks again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants