Skip to content

Deserialize enums in fallback Enum.Parse as case insensitive #4833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2020
Merged

Deserialize enums in fallback Enum.Parse as case insensitive #4833

merged 1 commit into from
Jul 1, 2020

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jun 30, 2020

This commit updates the EnumFormatter to parse case-insensitive
when falling back to the Enum.Parse method, which happens when
a value is not found in a mapping built from EnumMember/DataMember
value or field name.

Fixes #4817

@russcam
Deserialize enums in fallback Enum.Parse as case insensitive
9ef0a4c 
This commit updates the EnumFormatter to parse case-insensitive
when falling back to the Enum.Parse method, which happens when
a value is not found in a mapping built from EnumMember/DataMember
value or field name.

Fixes #4817
Mpdreamz
Mpdreamz approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam russcam merged commit 09ac0c5 into master Jul 1, 2020
@russcam russcam deleted the fix/4817 branch July 1, 2020 23:26
github-actions bot pushed a commit that referenced this pull request Jul 1, 2020
@russcam @github-actions
Deserialize enums in fallback Enum.Parse as case insensitive (#4833)
2eae8f6 
This commit updates the EnumFormatter to parse case-insensitive
when falling back to the Enum.Parse method, which happens when
a value is not found in a mapping built from EnumMember/DataMember
value or field name.

Fixes #4817
@github-actions github-actions bot mentioned this pull request Jul 1, 2020
Merged
github-actions bot pushed a commit that referenced this pull request Jul 1, 2020
@russcam @github-actions
Deserialize enums in fallback Enum.Parse as case insensitive (#4833)
9529533 
This commit updates the EnumFormatter to parse case-insensitive
when falling back to the Enum.Parse method, which happens when
a value is not found in a mapping built from EnumMember/DataMember
value or field name.

Fixes #4817
@github-actions github-actions bot mentioned this pull request Jul 1, 2020
Merged
russcam added a commit that referenced this pull request Jul 1, 2020
@github-actions @russcam
Deserialize enums in fallback Enum.Parse as case insensitive (#4833) (#…
fd9ce4d 
…4842)

This commit updates the EnumFormatter to parse case-insensitive
when falling back to the Enum.Parse method, which happens when
a value is not found in a mapping built from EnumMember/DataMember
value or field name.

Fixes #4817

Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam added a commit that referenced this pull request Jul 1, 2020
@github-actions @russcam
Deserialize enums in fallback Enum.Parse as case insensitive (#4833) (#…
264b23a 
…4843)

This commit updates the EnumFormatter to parse case-insensitive
when falling back to the Enum.Parse method, which happens when
a value is not found in a mapping built from EnumMember/DataMember
value or field name.

Fixes #4817

Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enum Parser should ignore case.
2 participants
@russcam @Mpdreamz