Skip to content

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jun 30, 2020

This commit checks that _cleanupTimer is not null
when disposing, which it may be if no requests have
been made.

Fixes #4818

This commit checks that _cleanupTimer is not null
when disposing, which it may be if no requests have
been made.

Fixes #4818
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@russcam russcam merged commit 6508843 into master Jul 1, 2020
@russcam russcam deleted the fix/4818 branch July 1, 2020 23:26
github-actions bot pushed a commit that referenced this pull request Jul 1, 2020
This commit checks that _cleanupTimer is not null
when disposing, which it may be if no requests have
been made.

Fixes #4818
github-actions bot pushed a commit that referenced this pull request Jul 1, 2020
This commit checks that _cleanupTimer is not null
when disposing, which it may be if no requests have
been made.

Fixes #4818
russcam added a commit that referenced this pull request Jul 1, 2020
This commit checks that _cleanupTimer is not null
when disposing, which it may be if no requests have
been made.

Fixes #4818

Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam added a commit that referenced this pull request Jul 1, 2020
This commit checks that _cleanupTimer is not null
when disposing, which it may be if no requests have
been made.

Fixes #4818

Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullReferenceException when disposing of ConnectionSettings
2 participants