Skip to content

Handle ISO8601 basic format offsets #4910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Handle ISO8601 basic format offsets #4910

merged 1 commit into from
Aug 4, 2020

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jul 31, 2020

This commit handles ISO8601 basic format offsets
of the form:

  • [+-]hh
  • [+-]hhmm

in addition to the extended format offset form

  • [+-]hh:mm

Fixes #4876

This commit handles ISO8601 basic format offsets
of the form:

- [+-]hh
- [+-]hhmm

in addition to the extended format offset form

- [+-]hh:mm

Fixes #4876
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM test failures unrelated see #4920

@russcam russcam merged commit 22a77dd into master Aug 4, 2020
@russcam russcam deleted the fix/4876 branch August 4, 2020 23:20
github-actions bot pushed a commit that referenced this pull request Aug 4, 2020
This commit handles ISO8601 basic format offsets
of the form:

- [+-]hh
- [+-]hhmm

in addition to the extended format offset form

- [+-]hh:mm

Fixes #4876
github-actions bot pushed a commit that referenced this pull request Aug 4, 2020
This commit handles ISO8601 basic format offsets
of the form:

- [+-]hh
- [+-]hhmm

in addition to the extended format offset form

- [+-]hh:mm

Fixes #4876
russcam added a commit that referenced this pull request Aug 4, 2020
This commit handles ISO8601 basic format offsets
of the form:

- [+-]hh
- [+-]hhmm

in addition to the extended format offset form

- [+-]hh:mm

Fixes #4876

Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam added a commit that referenced this pull request Aug 4, 2020
This commit handles ISO8601 basic format offsets
of the form:

- [+-]hh
- [+-]hhmm

in addition to the extended format offset form

- [+-]hh:mm

Fixes #4876

Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam added a commit that referenced this pull request Aug 5, 2020
Relates: #4910

The PR introduced a fix to support basic offset formats
when deserializing Iso8601, but the fix would only work with
7 fractional second values. This commit fixes the implementation
to support any number of fractional second values.
russcam added a commit that referenced this pull request Aug 5, 2020
Relates: #4910

The PR introduced a fix to support basic offset formats
when deserializing Iso8601, but the fix would only work with
7 fractional second values. This commit fixes the implementation
to support any number of fractional second values.

(cherry picked from commit f176653)
russcam added a commit that referenced this pull request Aug 5, 2020
Relates: #4910

The PR introduced a fix to support basic offset formats
when deserializing Iso8601, but the fix would only work with
7 fractional second values. This commit fixes the implementation
to support any number of fractional second values.

(cherry picked from commit f176653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deserialization Failure
2 participants