Skip to content

[DOCS] Fixes broken link to sliced scroll #4921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Aug 4, 2020

Related to elastic/docs#1932

This PR fixes the following links that will break when the "current" documentation branch becomes 7.9:

13:54:52 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/elasticsearch/client/net-api/7.x/scrolling-documents.html:
13:54:52 INFO:build_docs:   - en/elasticsearch/reference/current/search-request-body.html#sliced-scroll
13:54:52 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/elasticsearch/client/net-api/current/scrolling-documents.html:
13:54:52 INFO:build_docs:   - en/elasticsearch/reference/current/search-request-body.html#sliced-scroll
13:54:52 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/elasticsearch/client/net-api/master/scrolling-documents.html:
13:54:52 INFO:build_docs:   - en/elasticsearch/reference/current/search-request-body.html#sliced-scroll

NOTE: This fixes changes the link to https://www.elastic.co/guide/en/elasticsearch/reference/7.9/paginate-search-results.html. It does not change the link to https://www.elastic.co/guide/en/elasticsearch/reference/7.9/paginate-search-results.html#slice-scroll since that section ID does not exist until current=7.9. If necessary, we can update the URL again after 7.9 is released.

@lcawl lcawl added Docs 7.x Relates to a 7.x client version labels Aug 4, 2020
@lcawl lcawl requested a review from russcam August 5, 2020 15:06
@lcawl lcawl marked this pull request as ready for review August 5, 2020 15:06
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lcawl!

@russcam russcam added backport 7.9 and removed 7.x Relates to a 7.x client version labels Aug 6, 2020
@russcam
Copy link
Contributor

russcam commented Aug 6, 2020

Added backport labels for 7.x and 7.9 which will trigger github actions to auto open PRs for those branches when this PR is merged in.

@lcawl lcawl merged commit 945ce5e into elastic:master Aug 6, 2020
@lcawl lcawl deleted the scrolling-links branch August 6, 2020 16:11
russcam pushed a commit that referenced this pull request Aug 7, 2020
russcam pushed a commit that referenced this pull request Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants