Short circuit in ToUrl to remove allocations when possible. #5002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of going through the code, I spotted a fairly trivial change which can reduce allocations during URL generation for endpoints where no route values need to be applied.
UrlLookup.ToUrl
can short-circuit in such cases to avoid duplicating the string and allocating a StringBuilder. For requests where no index is supplied, the allocations can be entirely removed and an 87% reduction in execution time can be achieved.The examples below test with the cluster health endpoints.
Before:
After: