Enable TCP states and ThreadPool stats #5003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to enable TCP and ThreadPool statistics to be collected when making a request, exposing these statistics on the IApiCallDetails on the response, as well as including in the debug information. Add documentation explaining how to include these statistics either on a global or per request basis.
|
Thoughts on including this in 7.9.1, or 7.10.0, @Mpdreamz ? |
Mpdreamz
approved these changes
Sep 7, 2020
There was a problem hiding this comment.
Change looks good and much welcomed! Definitely can go out in 7.9.1
I wonder if it might be good to create include these types under https://github.com/elastic/elasticsearch-net/tree/master/src/Elasticsearch.Net/Diagnostics and in the Diagnostics namespace?
| debugCompletedRequestHandler.Invoke(d); | ||
| }; | ||
| }); | ||
| _completedRequestHandler += v ?? (d => Debug.WriteLine(d.DebugInformation))); |
I was initially thinking of putting them there, then wondered if that should strictly be for |
|
Failures are related to transforms; opened #5004 to address |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 8, 2020
This commit adds the ability to enable TCP and ThreadPool statistics to be collected when making a request, exposing these statistics on the IApiCallDetails on the response, as well as including in the debug information. Add documentation explaining how to include these statistics either on a global or per request basis.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 8, 2020
This commit adds the ability to enable TCP and ThreadPool statistics to be collected when making a request, exposing these statistics on the IApiCallDetails on the response, as well as including in the debug information. Add documentation explaining how to include these statistics either on a global or per request basis.
russcam
added a commit
that referenced
this pull request
Sep 8, 2020
This commit adds the ability to enable TCP and ThreadPool statistics to be collected when making a request, exposing these statistics on the IApiCallDetails on the response, as well as including in the debug information. Add documentation explaining how to include these statistics either on a global or per request basis. Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam
added a commit
that referenced
this pull request
Sep 8, 2020
* Enable TCP states and ThreadPool stats (#5003) This commit adds the ability to enable TCP and ThreadPool statistics to be collected when making a request, exposing these statistics on the IApiCallDetails on the response, as well as including in the debug information. Add documentation explaining how to include these statistics either on a global or per request basis. Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to enable TCP and ThreadPool
statistics to be collected when making a request, exposing
these statistics on the IApiCallDetails on the response, as
well as including in the debug information.
Add documentation explaining how to include these statistics
either on a global or per request basis.