Collect MemberInfo same as Json.NET when building a formatter #5009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will refactor this further and provide additional documentation to clarify how it works |
russcam
force-pushed
the
property-serialization
branch
2 times, most recently
from
d537c5c to
6f34e4b
Compare
This commit removes the GetMember call when resolving MemberInfo for a type, whilst creating the property mapping. This aligns 7.x implementation with 6.x and 5.x
This commit changes how type property MemberInfo are collected when using MetaType to IL generate the formatter for a type. This change brings collection with Utf8Json in line with how Json.NET collects properties in https://github.com/JamesNK/Newtonsoft.Json/blob/666d9760719e5ec5b2a50046f7dbd6a1267c01c6/Src/Newtonsoft.Json/Utilities/ReflectionUtils.cs#L928-L957 Fixes #4958
This commit removes the use of TypeInfo from the projects. TypeInfo was introduced when full reflection was not available in .NET Core and the libraries supported NetStandard 1.3. Now that the minimum TFMs supported are .NET 4.6.1 and .NET Standard 2.0, there's no need to use TypeInfo.
russcam
force-pushed
the
property-serialization
branch
from
6f34e4b to
4bab3cd
Compare
|
This is now ready for review |
Mpdreamz
reviewed
Sep 15, 2020
|
|
||
| // requires lock on mono environment. see: https://github.com/neuecc/MessagePack-CSharp/issues/161 | ||
| // requires lock on mono environment. see: https://github.com/neuecc/MessagePack-CSharp/issues/161 |
There was a problem hiding this comment.
Should we reformat the files as well?
This commit removes Utf8Json types that are not used in the client, and formats the remaining code to align with the conventions of the codebase. Remove the .editorconfig in the Utf8Json directory
This commit aligns the implementation for retrieving properties when determining property mapping for a type with the way that properties are retrieved when generating a serialization formatter for a type, in relation to how member hiding and overridden members are determined. Replace usages of GetGetMethod() with the GetMethod property and GetSetMethod() with the SetMethod property.
This commit adds documentation for how to model documents in Elasticsearch with types in a .NET project. It aims to show some of the nuances around serialization in relation to type hierarchies.
russcam
force-pushed
the
property-serialization
branch
from
4b1f1f1 to
aa0ef46
Compare
|
@elasticmachine run elasticsearch-ci/docs |
This was referenced Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how type property
MemberInfoare collected when usingMetaTypeto IL generate the formatter for a type. This change brings collection with Utf8Json in line with how Json.NET collects properties inhttps://github.com/JamesNK/Newtonsoft.Json/blob/666d9760719e5ec5b2a50046f7dbd6a1267c01c6/Src/Newtonsoft.Json/Utilities/ReflectionUtils.cs#L928-L957
In addition, remove the GetMember call when resolving MemberInfo for a type, whilst creating the property mapping. This aligns 7.x implementation with 6.x and 5.x
Fixes #4958