Make API generation non interactive #5078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now is non interactive by default and can be controlled with commandline arguments. Proper cancellation support to cancel generation. Cleaned up console output a bit
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Mpdreamz
added a commit
that referenced
this pull request
Nov 9, 2020
(cherry picked from commit 06d9c52)
Mpdreamz
added a commit
that referenced
this pull request
Nov 9, 2020
|
Manually backported to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
ApiGeneratorcould only be run interactively.This PR adds proper flags and help and makes the tool non-interactive by default.
In addition to this we switched to async everywhere allowing the tool to be interopted using e.g
CTRL+C.