[Backport 7.x] Update to .NET 5 SDK (#5099) #5107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to .NET 5 SDK * Update InternalsVisibleTo as .NET 5 SDK now supports passing a key * Fix test after upgrading tests to net5.0 In .NET 5, System.Text.Json added support for creating types using a constructor with parameters. Despite the internal parameterless ctor being accessible, STJ is not using it. The solution for now seems to be to make this public. (cherry picked from commit fa2edcc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In .NET 5, System.Text.Json added support for creating types using a
constructor with parameters. Despite the internal parameterless ctor
being accessible, STJ is not using it. The solution for now seems to be
to make this public.
(cherry picked from commit fa2edcc)