Update BoxplotAggregate response #5133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 7.11 the boxplot aggregation response includes two additional properties, lower and upper. I've added these to our type and updated the deserialization to handle these when present.
Mpdreamz
approved these changes
Nov 30, 2020
|
@Mpdreamz Sounds good. I'll drop the backport to 7.10 and put in a fresh PR to adjust accordingly. Would such changes to avoid the exception be needed in patches of 7.9 and earlier? Should 7.9.x client work with a 7.11.0 cluster? |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 30, 2020
In 7.11 the boxplot aggregation response includes two additional properties, lower and upper. I've added these to our type and updated the deserialization to handle these when present.
stevejgordon
added a commit
that referenced
this pull request
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7.11 the boxplot aggregation response includes two additional properties, lower and upper. I've added these to our type and updated the deserialization to handle these when present.