Skip to content

Conversation

stevejgordon
Copy link
Contributor

This adds support for the new open/close point in time APIs.

Contributes to #5096

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM small note on SkipVersion

Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
@@ -13,6 +13,7 @@

namespace Tests.Search.PointInTime.Close
{
[SkipVersion("<7.10.0", "Api introduced in 7.10.0")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs namespace imports :)

@stevejgordon stevejgordon merged commit 2d9502a into 7.10 Nov 30, 2020
@stevejgordon stevejgordon deleted the feature/point-in-time branch November 30, 2020 17:08
@github-actions
Copy link
Contributor

The backport to 7.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.x 7.x
# Navigate to the new working tree
cd .worktrees/backport-7.x
# Create a new branch
git switch --create backport-5137-to-7.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 2d9502aaccf1f2033fba211f07710025410de6fa
# Push it to GitHub
git push --set-upstream origin backport-5137-to-7.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.x

Then, create a pull request where the base branch is 7.x and the compare/head branch is backport-5137-to-7.x.

@github-actions
Copy link
Contributor

The backport to master failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-master master
# Navigate to the new working tree
cd .worktrees/backport-master
# Create a new branch
git switch --create backport-5137-to-master
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 2d9502aaccf1f2033fba211f07710025410de6fa
# Push it to GitHub
git push --set-upstream origin backport-5137-to-master
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-master

Then, create a pull request where the base branch is master and the compare/head branch is backport-5137-to-master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants