Skip to content

Conversation

stevejgordon
Copy link
Contributor

@stevejgordon stevejgordon commented Dec 1, 2020

Contributes to #5096

Perhaps requires a simple test derived from ApiTestBase to assert on the expected JSON, URL etc? These are pretty much exercised by the main coordinated test.

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stevejgordon stevejgordon merged commit 75ba1f1 into 7.10 Dec 4, 2020
@stevejgordon stevejgordon deleted the feature/security-grant-api branch December 4, 2020 09:45
github-actions bot pushed a commit that referenced this pull request Dec 4, 2020
github-actions bot pushed a commit that referenced this pull request Dec 4, 2020
stevejgordon added a commit that referenced this pull request Dec 7, 2020
Contributes to #5096

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon added a commit that referenced this pull request Dec 8, 2020
* Implement grant API key (#5142)

Contributes to #5096

* Manual fix-up of namespaces

* Manual test namespace fixes

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants