Skip to content

[Backport master] Fix bug in AutoExpandReplicas.Create #5262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2021
Merged

[Backport master] Fix bug in AutoExpandReplicas.Create #5262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Nest/IndexModules/IndexSettings/Settings/AutoExpandReplicas.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ public static AutoExpandReplicas Create(string value)
if (value.IsNullOrEmpty())
throw new ArgumentException("cannot be null or empty", nameof(value));

if (value.Equals("false", StringComparison.OrdinalIgnoreCase))
return Disabled;

var expandReplicaParts = value.Split('-');
if (expandReplicaParts.Length != 2)
throw new ArgumentException("must contain a 'from' and 'to' value", nameof(value));
Expand Down
11 changes: 11 additions & 0 deletions tests/Tests/CommonOptions/AutoExpandReplicas/AutoExpandReplicasTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,17 @@ public void CreateWithMinAndAll()
autoExpandReplicas.ToString().Should().Be("0-all");
}

[U]
public void CreateWithFalse()
{
var autoExpandReplicas = Nest.AutoExpandReplicas.Create("false");
autoExpandReplicas.Should().NotBeNull();
autoExpandReplicas.Enabled.Should().BeFalse();
autoExpandReplicas.MinReplicas.Should().BeNull();
autoExpandReplicas.MaxReplicas.Should().BeNull();
autoExpandReplicas.ToString().Should().Be("false");
}

[U]
public void Disabled()
{
Expand Down