enhancement/ienumerable searchafter descriptor #5417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevejgordon
added a commit
that referenced
this pull request
Mar 22, 2021
stevejgordon
added a commit
that referenced
this pull request
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5416.
Since the sort from a previous search is represented as
IReadOnlyCollection<object>it's reasonable that consumers may want to pass this unaltered into the next search. TheSearchRequestdefines this property as anIList<object>which we can't address without breaking changes. However, this PR can improve the fluent usage by providing anIEnumerable<object>overload, avoiding the need to callToList()orToArray()on the previous sort.