Check _cleanupTimer is not null when disposing (backport fix/4818 to 6.x) #5530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backporting fix for elastic#4818 This commit checks that _cleanupTimer is not null when disposing, which it may be if no requests have been made. Fixes elastic#5529
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
bdchris
changed the title
|
Thanks for contributing @bdchris. Some of the tests timed out but the key ones have passed. I'll merge this in and run the tests again locally. |
|
@stevejgordon is there a page or other media that shows schedule for v6.8.8 ? |
|
@bdchris - There's no specific schedule for patch releases. My plan right now is to target the next release within the next 8-10 business days. |
|
sounds good @stevejgordon - thanks much! |
|
@bdchris I've released 6.8.8 of the client this morning which includes your bug fix. |
cdonnellytx
pushed a commit
to cdonnellytx/elasticsearch-net
that referenced
this pull request
Jun 14, 2021
…er run command (elastic#5333) (cherry picked from commit c8f2b38)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting fix for #4818
This commit checks that _cleanupTimer is not null when disposing, which it may be if no requests have been made.
Fixes #5529