Skip to content

Ensure we dispose of the response stream in all cases #5785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

stevejgordon
Copy link
Contributor

Repeat calls to ExistsAsync can cause the connection limit to be reached as the optimized code which ensures we correctly handle cloud responses may not always run, leaving the response stream and therefore the connection open. This causes the default connection limit of 80 to be reached.

This fix ensures we correctly dispose of the response stream in all code paths.

Fixes #5775

@stevejgordon stevejgordon merged commit 364ca23 into 7.x Jul 5, 2021
@stevejgordon stevejgordon deleted the bug/dispose-stream branch July 5, 2021 09:52
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2021

The backport to 7.13 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.13 7.13
# Navigate to the new working tree
cd .worktrees/backport-7.13
# Create a new branch
git switch --create backport-5785-to-7.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 364ca23274e891edbca6473290100bbfc521dbbd
# Push it to GitHub
git push --set-upstream origin backport-5785-to-7.13
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.13

Then, create a pull request where the base branch is 7.13 and the compare/head branch is backport-5785-to-7.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant