[perf] Reduce allocations on some transport paths #5865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazily caches the Uri on RequestData since this property is accessed at least three times and each time was allocating a new Uri. This saves 192 bytes per request.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 13, 2021
* Cache RequestData.Uri once created Lazily caches the Uri on RequestData since this property is accessed at least three times and each time was allocating a new Uri. This saves 192 bytes per request. * Ensure we reset the Uri if the Node changes
stevejgordon
added a commit
that referenced
this pull request
Jul 13, 2021
* Cache RequestData.Uri once created Lazily caches the Uri on RequestData since this property is accessed at least three times and each time was allocating a new Uri. This saves 192 bytes per request. * Ensure we reset the Uri if the Node changes Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazily caches the Uri on RequestData since this property is accessed at least three times and each time was allocating a new Uri. This saves 192 bytes per request.
This optimisation is one of three added to the new
Elastic.Transportproject that was suitable to backport to 7.x.