Refine product check behaviour #5913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that if the consumer catches the exception and reuses the client which has previously failed the check, the failure exception is raised.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 22, 2021
* Rework transient errors * Update tests * Update docs * Cleanup * Hide ProductCheckStatus on implementations * Further cleanup during testing * Reset scratch pad * Fix comments * Ensure we raise product check error as neccesary This ensures that if the consumer catches the exception and reuses the client which has previously failed the check, the failure exception is raised. * Update bulk all test which now fails due to product check
stevejgordon
added a commit
that referenced
this pull request
Jul 22, 2021
* Rework transient errors * Update tests * Update docs * Cleanup * Hide ProductCheckStatus on implementations * Further cleanup during testing * Reset scratch pad * Fix comments * Ensure we raise product check error as neccesary This ensures that if the consumer catches the exception and reuses the client which has previously failed the check, the failure exception is raised. * Update bulk all test which now fails due to product check
stevejgordon
added a commit
that referenced
this pull request
Jul 22, 2021
* Rework transient errors * Update tests * Update docs * Cleanup * Hide ProductCheckStatus on implementations * Further cleanup during testing * Reset scratch pad * Fix comments * Ensure we raise product check error as neccesary This ensures that if the consumer catches the exception and reuses the client which has previously failed the check, the failure exception is raised. * Update bulk all test which now fails due to product check Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.