Skip to content

Conversation

stevejgordon
Copy link
Contributor

The RangeQueryBuilder, used to generate queries returned by the Translate API, is including properties considered to be deprecated. In order to support deserialisation of the returned query and to search using it, this PR adds the necessary properties to the range queries. These are marked as obsolete as we intend to remove them in the near future and don't expect consumers to set them for their own queries. They are intended purely to support the translated query response.

  • Support deprecated properties on range queries
  • Support deserialisation of new properties via the RangeQueryFormatter
  • Allow skipping some checks in code standards. The deprecated properties are not included as assignment methods on the fluent descriptor and as such our test for bool properties on descriptors was failing. This PR includes a change to allow certain properties to be skipped from such checks.

@stevejgordon stevejgordon merged commit 4125cf9 into 7.x Oct 28, 2021
@stevejgordon stevejgordon deleted the fix/range-query-from-translate branch October 28, 2021 08:51
@github-actions
Copy link
Contributor

The backport to 7.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.15 7.15
# Navigate to the new working tree
cd .worktrees/backport-7.15
# Create a new branch
git switch --create backport-6042-to-7.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 4125cf9108675168719999e68ac62b7da45713a9
# Push it to GitHub
git push --set-upstream origin backport-6042-to-7.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.15

Then, create a pull request where the base branch is 7.15 and the compare/head branch is backport-6042-to-7.15.

stevejgordon added a commit that referenced this pull request Oct 28, 2021
* Initial work to support deprecated properties

* Support additional deprecated properties on range query

* Allow skipping some checks in code standards

(cherry picked from commit 4125cf9)
stevejgordon added a commit that referenced this pull request Oct 28, 2021
* Initial work to support deprecated properties

* Support additional deprecated properties on range query

* Allow skipping some checks in code standards

(cherry picked from commit 4125cf9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant