Remove IElasticsearchClient interface #6161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have deemed that this interface is not all that useful as it may change between versions if APIs are added, which ends up breaking and implementations. It's not super useful for testing scenarios and we'll look to provide better options and documentation instead.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2022
Remove IElasticsearchClient interface. We have deemed that this interface is not all that useful as it may change between versions if APIs are added, which ends up breaking and implementations. It's not super useful for testing scenarios and we'll look to provide better options and documentation instead.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2022
Remove IElasticsearchClient interface. We have deemed that this interface is not all that useful as it may change between versions if APIs are added, which ends up breaking and implementations. It's not super useful for testing scenarios and we'll look to provide better options and documentation instead.
stevejgordon
added a commit
that referenced
this pull request
Mar 18, 2022
Remove IElasticsearchClient interface. We have deemed that this interface is not all that useful as it may change between versions if APIs are added, which ends up breaking and implementations. It's not super useful for testing scenarios and we'll look to provide better options and documentation instead. Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon
added a commit
that referenced
this pull request
Mar 18, 2022
Remove IElasticsearchClient interface. We have deemed that this interface is not all that useful as it may change between versions if APIs are added, which ends up breaking and implementations. It's not super useful for testing scenarios and we'll look to provide better options and documentation instead. Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have deemed that this interface is not all that useful as it may change between versions when APIs are added, which ends up breaking any implementations. It's not super useful for testing scenarios and we'll look to provide better options and documentation instead.