Skip to content

Fix PositionLength JSON name on AnalyzeToken #6259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

Ferran54
Copy link

@Ferran54 Ferran54 commented Apr 7, 2022

api return positionLength but nest is expecting a different name, so it is always null on nest response.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Apr 7, 2022

💚 CLA has been signed

Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and fixing it with this PR. LGTM!

@stevejgordon
Copy link
Contributor

Fixes #6258

@stevejgordon stevejgordon changed the title wrong jsonproperty name Fix PositionLength JSON name on AnalyzeToken Apr 13, 2022
@stevejgordon
Copy link
Contributor

Tests are passing locally so will ignore the CI issues here which are unrelated.

@stevejgordon stevejgordon merged commit 05938a3 into elastic:6.x Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants