-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Generate sorting types #6511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Generate sorting types #6511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
* Removal of manual handling for sorts * Additional sort types * Renamed container factory method args * Improve container + additional property serialisation * Simplify properties which are single or many * Updated serialisation with tests passing * Fix BOM and update test
github-actions bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
* Removal of manual handling for sorts * Additional sort types * Renamed container factory method args * Improve container + additional property serialisation * Simplify properties which are single or many * Updated serialisation with tests passing * Fix BOM and update test
github-actions bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
* Removal of manual handling for sorts * Additional sort types * Renamed container factory method args * Improve container + additional property serialisation * Simplify properties which are single or many * Updated serialisation with tests passing * Fix BOM and update test
github-actions bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
* Removal of manual handling for sorts * Additional sort types * Renamed container factory method args * Improve container + additional property serialisation * Simplify properties which are single or many * Updated serialisation with tests passing * Fix BOM and update test
stevejgordon
added a commit
that referenced
this pull request
Jul 11, 2022
* Removal of manual handling for sorts * Additional sort types * Renamed container factory method args * Improve container + additional property serialisation * Simplify properties which are single or many * Updated serialisation with tests passing * Fix BOM and update test Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon
added a commit
that referenced
this pull request
Jul 11, 2022
* Removal of manual handling for sorts * Additional sort types * Renamed container factory method args * Improve container + additional property serialisation * Simplify properties which are single or many * Updated serialisation with tests passing * Fix BOM and update test Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon
added a commit
that referenced
this pull request
Jul 11, 2022
* Removal of manual handling for sorts * Additional sort types * Renamed container factory method args * Improve container + additional property serialisation * Simplify properties which are single or many * Updated serialisation with tests passing * Fix BOM and update test Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon
added a commit
that referenced
this pull request
Jul 11, 2022
* Removal of manual handling for sorts * Additional sort types * Renamed container factory method args * Improve container + additional property serialisation * Simplify properties which are single or many * Updated serialisation with tests passing * Fix BOM and update test Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes manual sort types, preferring code-generated types for API consistency.