Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complted buckets JSON converter #7738

Merged
merged 3 commits into from Jul 10, 2023
Merged

Complted buckets JSON converter #7738

merged 3 commits into from Jul 10, 2023

Conversation

YohDeadfall
Copy link
Contributor

Fixes #7713.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@technige
Copy link

Thank you for your submission. We will review this in due course as and when someone is available on the team to do so.

@YohDeadfall
Copy link
Contributor Author

Thank you for getting here, @technige, but could you turn the pipelines on so these ad other changes can be tested before an Elastic member comes here?

@OlegoO
Copy link

OlegoO commented Jun 27, 2023

@technige Any ideas, when are you will able to merge it or create alfa version? Without aggregations we could not completely migrate from Nest and use a library in e-commerce platform.

@YohDeadfall
Copy link
Contributor Author

@OlegoO, the problem here as I understand that Elastic has no .NET developers at the moment and no one is maintaining that repository. So, I would suggest you making a fork with that fix and publish the resulting package on your own NuGet server or git submodule it and reference as a project.

@flobernd
Copy link
Member

flobernd commented Jul 4, 2023

Hi @YohDeadfall, thanks for your contribution(s)! I'm the new maintainer for this repository and I'm currently familiarizing myself with the code base and trying to catch up with the existing issues/PRs.

I can't give you an exact ETA, but I'm hoping to be able to check this PR until next week. Just wanted to let you know, that I'm actively working on it.

@YohDeadfall
Copy link
Contributor Author

Awesome! Since all my contributions are serialization related that should not be hard to review them. Feel free to reach me out on any question about my contributions here or the JSON serializer in general in which creation I participated in.

@flobernd flobernd added bug 8.x Relates to 8.x client version labels Jul 5, 2023
flobernd
flobernd approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@YohDeadfall
Copy link
Contributor Author

Now you need to allow pipelines to run, @flobernd (:

@flobernd flobernd merged commit 5732df0 into elastic:main Jul 10, 2023
12 checks passed
@YohDeadfall YohDeadfall deleted the buckets-converter branch July 10, 2023 11:49
flobernd pushed a commit that referenced this pull request Jul 10, 2023
@YohDeadfall @flobernd
Complted buckets JSON converter (#7738)
6f68387
flobernd added a commit that referenced this pull request Jul 11, 2023
@flobernd @karl-sjogren @YohDeadfall
Community backports for 8.1.3 (#7793)
51035b7 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @karl-sjogren
@YohDeadfall @github-actions
Community backports for 8.1.3 (#7793)
4cdd367 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @karl-sjogren
@YohDeadfall @github-actions
Community backports for 8.1.3 (#7793)
734bb4f 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @karl-sjogren
@YohDeadfall @github-actions
Community backports for 8.1.3 (#7793)
8ca569d 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @karl-sjogren
@YohDeadfall @github-actions
Community backports for 8.1.3 (#7793)
e9ba022 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @karl-sjogren
@YohDeadfall @github-actions
Community backports for 8.1.3 (#7793)
ef5e577 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @karl-sjogren
@YohDeadfall @github-actions
Community backports for 8.1.3 (#7793)
ab9f90e 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @karl-sjogren
@YohDeadfall @github-actions
Community backports for 8.1.3 (#7793)
354666d 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @karl-sjogren
@YohDeadfall @github-actions
Community backports for 8.1.3 (#7793)
074b876 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
@karl-sjogren @YohDeadfall
Community backports for 8.1.3 (#7793) (#7803)
77863ca 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Florian Bernd <git@flobernd.de>
Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
@karl-sjogren @YohDeadfall
Community backports for 8.1.3 (#7793) (#7804)
ec5a558 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Florian Bernd <git@flobernd.de>
Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
@karl-sjogren @YohDeadfall
Community backports for 8.1.3 (#7793) (#7805)
37681f8 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Florian Bernd <git@flobernd.de>
Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
@karl-sjogren @YohDeadfall
Community backports for 8.1.3 (#7793) (#7806)
0940ed4 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Florian Bernd <git@flobernd.de>
Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
@karl-sjogren @YohDeadfall
Community backports for 8.1.3 (#7793) (#7807)
c3aef53 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Florian Bernd <git@flobernd.de>
Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
@karl-sjogren @YohDeadfall
Community backports for 8.1.3 (#7793) (#7808)
8df2bc9 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Florian Bernd <git@flobernd.de>
Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
@karl-sjogren @YohDeadfall
Community backports for 8.1.3 (#7793) (#7809)
8a9f285 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Florian Bernd <git@flobernd.de>
Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
@karl-sjogren @YohDeadfall
Community backports for 8.1.3 (#7793) (#7810)
35346ee 
* DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

* Complted buckets JSON converter (#7738)

* Boosted non-exhaustive enum deserialization (#7737)

* Optimized `FieldConverter` (#7736)

* Removed unused JsonIgnore (#7735)

* Fixed the equality contract on Metrics type (#7733)

* No allocations in ResponseItem IsValid prop (#7731)

* Refactoring and tiny behavior fix for Ids (#7730)

---------

Co-authored-by: Florian Bernd <git@flobernd.de>
Co-authored-by: Karl-Johan Sjögren <karl.sjogren@gmail.com>
Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flobernd flobernd flobernd approved these changes

Assignees
No one assigned
Labels
8.x Relates to 8.x client version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FiltersAggregation doesn't work due to missing JsonConverter implementation
5 participants
@YohDeadfall @elasticmachine @technige @OlegoO @flobernd