Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix localization issue with floating-point deserialization from string #7811

Merged
merged 1 commit into from Jul 11, 2023
Merged

Fix localization issue with floating-point deserialization from string #7811

merged 1 commit into from Jul 11, 2023

Conversation

flobernd
Copy link
Member

Fixes deserialization of "floating-point strings" on machines with German localization:

 FAIL  Tests.Serialization.SourceSerializationForNumericPropertiesTests.DoubleAsString_DeserializesCorrectly
       Expected deserialized.Double to be 1.0, but found 10.0.
..........................................................................
 FAIL  Tests.Common.Fields.FieldValueTests.CanSerialize_DoubleFieldValueKind
       Expected result.FieldValue.ToString() to be "1.1", but "1,1" differs near ",1" (index 1).

@flobernd flobernd added bug 8.x Relates to 8.x client version labels Jul 11, 2023
stevejgordon
stevejgordon approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flobernd flobernd merged commit fba4348 into main Jul 11, 2023
34 checks passed
@flobernd flobernd deleted the fix-fp-localization branch July 11, 2023 14:00
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @github-actions
Fix localization issue with floating-point deserialization from string (
de992e7 
#7811)
This was referenced Jul 11, 2023
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @github-actions
Fix localization issue with floating-point deserialization from string (
12a9168 
#7811)
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @github-actions
Fix localization issue with floating-point deserialization from string (
93ee2e8 
#7811)
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @github-actions
Fix localization issue with floating-point deserialization from string (
ca3e875 
#7811)
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @github-actions
Fix localization issue with floating-point deserialization from string (
9488ce5 
#7811)
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @github-actions
Fix localization issue with floating-point deserialization from string (
5324b6f 
#7811)
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @github-actions
Fix localization issue with floating-point deserialization from string (
2755dae 
#7811)
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @github-actions
Fix localization issue with floating-point deserialization from string (
4b13248 
#7811)
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@flobernd @github-actions
Fix localization issue with floating-point deserialization from string (
8b10490 
#7811)
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
Fix localization issue with floating-point deserialization from string (
4bbde6d 
#7811) (#7813)

Co-authored-by: Florian Bernd <git@flobernd.de>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
Fix localization issue with floating-point deserialization from string (
ad73de9 
#7811) (#7814)

Co-authored-by: Florian Bernd <git@flobernd.de>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
Fix localization issue with floating-point deserialization from string (
8f62b48 
#7811) (#7815)

Co-authored-by: Florian Bernd <git@flobernd.de>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
Fix localization issue with floating-point deserialization from string (
f321ef9 
#7811) (#7816)

Co-authored-by: Florian Bernd <git@flobernd.de>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
Fix localization issue with floating-point deserialization from string (
db25ae0 
#7811) (#7817)

Co-authored-by: Florian Bernd <git@flobernd.de>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
Fix localization issue with floating-point deserialization from string (
989d76f 
#7811) (#7818)

Co-authored-by: Florian Bernd <git@flobernd.de>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
Fix localization issue with floating-point deserialization from string (
8e58c8c 
#7811) (#7819)

Co-authored-by: Florian Bernd <git@flobernd.de>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
Fix localization issue with floating-point deserialization from string (
0ef87ec 
#7811) (#7820)

Co-authored-by: Florian Bernd <git@flobernd.de>
flobernd added a commit that referenced this pull request Jul 11, 2023
@github-actions @flobernd
Fix localization issue with floating-point deserialization from string (
bc495cb 
#7811) (#7821)

Co-authored-by: Florian Bernd <git@flobernd.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevejgordon stevejgordon stevejgordon approved these changes

@Mpdreamz Mpdreamz Awaiting requested review from Mpdreamz

Assignees
No one assigned
Labels
8.x Relates to 8.x client version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flobernd @stevejgordon