Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve serialization of "single-or-many" properties #8090

Merged
merged 1 commit into from Apr 5, 2024
Merged

Improve serialization of "single-or-many" properties #8090

merged 1 commit into from Apr 5, 2024

Conversation

flobernd
Copy link
Member

@flobernd flobernd commented Apr 5, 2024

Closes #8056

stevejgordon
stevejgordon reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The serialization changes look okay to me. It would probably be worth adding some test cases for these now we have a reasonable understanding of the nuances of the API and the expected formats of the data.

@flobernd
Copy link
Member Author

flobernd commented Apr 5, 2024

That's definitely a good idea. I'll add some tests in a following step after I updated the tests for 8.13 in general 🙂

@flobernd flobernd merged commit 5ccd393 into main Apr 5, 2024
10 of 24 checks passed
@flobernd flobernd deleted the fix-empty-single-or-many-descriptor branch April 5, 2024 13:01
github-actions bot pushed a commit that referenced this pull request Apr 5, 2024
@flobernd @github-actions
Improve serialization of "single-or-many" properties (#8090)
227206d
@github-actions github-actions bot mentioned this pull request Apr 5, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Apr 5, 2024
@flobernd @github-actions
Improve serialization of "single-or-many" properties (#8090)
a7b09da
@github-actions github-actions bot mentioned this pull request Apr 5, 2024
Merged
flobernd added a commit that referenced this pull request Apr 5, 2024
@github-actions @flobernd
Improve serialization of "single-or-many" properties (#8090) (#8094)
c182754 
Co-authored-by: Florian Bernd <git@flobernd.de>
flobernd added a commit that referenced this pull request Apr 5, 2024
@github-actions @flobernd
Improve serialization of "single-or-many" properties (#8090) (#8093)
a11e951 
Co-authored-by: Florian Bernd <git@flobernd.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevejgordon stevejgordon stevejgordon left review comments

Assignees
No one assigned
Labels
8.x Relates to 8.x client version Area: Generator backport serverless backport 8.13 Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty should collection is serialized improperly
2 participants
@flobernd @stevejgordon