Introduce RequestResponseConverter<T> and make all non-generated JsonConverters public
#8669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Converter`s public
flobernd
force-pushed
the
request-response-serializer
branch
from
eb2c809 to
a7a5a18
Compare
flobernd
force-pushed
the
request-response-serializer
branch
from
33bf55c to
8495795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RequestResponseConverter<T>allows to (de-)serialize certain properties of user defined document POCO types using theRequestResponseserializer.This is important in cases where the document must contain
Elastic.Clients.Elasticsearchtypes like e.g. when storing percolated queries.Additionally makes all handcrafted
JsonConverters public (using a.Jsonsub-namespace of the type). This is a requirement to be compatible withSystem.Text.Jsonsource-generation (JsonSerializerContextandJsonSerializableattribute).