Adding key to a date range aggregation #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @taschmidt, this LGTM, thanks! Would you mind signing the CLA? |
|
Done. Thanks! Are you planning a nuget pkg update anytime soon? |
gmarz
added a commit
that referenced
this pull request
Sep 10, 2014
Adding key to a date range aggregation
|
Yup, we're aiming to release 1.1.0 next week. Thanks again for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing a date range aggregation with a series of date ranges, but ES returns them in descending count order, not how I submitted them. Without the key, I didn't have a decent way of telling the aggregations apart to display to the end user.