Search template support #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tterate over it together
* Mapped to search template endpoint * Class/method renaming and folder structuring * Unit tests to demonstrate syntax
…lasticsearch-net into feauture/search-template Conflicts: src/Tests/Nest.Tests.Unit/Template/TemplateSpikeTests.cs
|
LGTM 👍 Seems like GET PUT DELETE Script are still unmapped while reviewing the diff, need to create a new ticket for that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multiple features related to search templates:
Note:
GetTemplate(),PutTemplate(), andDeleteTemplate()methods on the client are for index templates. We should consider renaming these in 2.0 toGetIndexTemplate(),PutIndexTemplate()andDeleteIndexTemplate()to reduce confusion between index and search templates.