Skip to content

FromAsString & ToAsString properties were not serializing #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

FromAsString & ToAsString properties were not serializing #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf48ba1
Fixed bug with RangeItem serialization.
Oct 15, 2014
2132664
Updated DateRangeItem UnitTest to check for valid to_as_string and fr…
Oct 15, 2014
f6f13d8
Fixed other potential JSON.NET deserialization of DateTime property v…
Oct 15, 2014
4ad890f
Revert "Fixed other potential JSON.NET deserialization of DateTime pr…
Oct 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Nest/Resolvers/Converters/Aggregations/AggregationConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,13 +366,11 @@ public IAggregation GetRangeAggregation(JsonReader reader, JsonSerializer serial
reader.Read();
break;
case "from_as_string":
reader.Read();
fromAsString = reader.Value as string;
fromAsString = reader.ReadAsString();
reader.Read();
break;
case "to_as_string":
reader.Read();
toAsString = reader.Value as string;
toAsString = reader.ReadAsString();
reader.Read();
break;
case "doc_count":
Expand Down
17 changes: 16 additions & 1 deletion src/Tests/Nest.Tests.Integration/Aggregations/ParseResponseItemsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Linq;
using System;
using System.Linq;
using Elasticsearch.Net;
using FluentAssertions;
using Nest.Tests.MockData.Domain;
Expand Down Expand Up @@ -180,6 +181,20 @@ public void DateRangeItem()
firstAgg.Items.Should().NotBeEmpty();
var grams = firstAgg.Items.OfType<RangeItem>();
grams.Should().NotBeEmpty();
var firstRange = grams.FirstOrDefault();
firstRange.Should().NotBeNull();
firstRange.To.Should().HaveValue();
firstRange.ToAsString.Should().NotBeNull();
var firstRangeToDateLeft = firstRange.To.Value.JavaTimeStampToDateTime();
var firstRangeToDateRight = DateTime.Parse(firstRange.ToAsString);
firstRangeToDateLeft.Should().Be(firstRangeToDateRight);
var lastRange = grams.LastOrDefault();
lastRange.Should().NotBeNull();
lastRange.From.Should().HaveValue();
lastRange.FromAsString.Should().NotBeNull();
var LastRangeFromDateLeft = lastRange.From.Value.JavaTimeStampToDateTime();
var LastRangeFromDateRight = DateTime.Parse(lastRange.FromAsString);
LastRangeFromDateLeft.Should().Be(LastRangeFromDateRight);
}
[Test]
public void IpRangeItem()
Expand Down