Skip to content

Conversation

slobodanadamovic
Copy link
Contributor

@slobodanadamovic slobodanadamovic commented Mar 20, 2024

This PR increases client's port ranges for tests which are executed on Windows in order to avoid failures due to some port ranges being excluded from use. The larger ports range (300) is chosen based on the observation where a random consecutive range of 200 ports can be excluded on Windows test workers.

Relates to #103894, which fixed similar issues but this one seems to have been missed.

Resolves: #106537

…rts on windows

This PR increases client's port ranges for tests which are executed
on Windows in order to avoid failures due to some port ranges being
excluded from use. The larger ports range (300) is chosen based on
the observation where a random consecutive range of 200 ports can
be excluded on Windows test workers.

Relates to: elastic#103894

Resolves: elastic#106537
@slobodanadamovic slobodanadamovic added >test Issues or PRs that are addressing/adding tests :Security/TLS SSL/TLS, Certificates Team:Security Meta label for security team v7.17.20 labels Mar 20, 2024
@slobodanadamovic slobodanadamovic self-assigned this Mar 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@jfreden jfreden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@slobodanadamovic slobodanadamovic added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 20, 2024
@elasticsearchmachine elasticsearchmachine merged commit 59f0e6f into elastic:7.17 Mar 20, 2024
@slobodanadamovic slobodanadamovic deleted the sa-fix-106537 branch March 20, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Security/TLS SSL/TLS, Certificates Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v7.17.20
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants