Skip to content

[Test] Fix SslMultiPortTests by increasing the number of ephemeral ports on Windows #106540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2024
Merged

[Test] Fix SslMultiPortTests by increasing the number of ephemeral ports on Windows #106540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions ...nalClusterTest/java/org/elasticsearch/xpack/security/transport/ssl/SslMultiPortTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/
package org.elasticsearch.xpack.security.transport.ssl;

import org.apache.lucene.util.Constants;
import org.elasticsearch.client.transport.NoNodeAvailableException;
import org.elasticsearch.client.transport.TransportClient;
import org.elasticsearch.common.network.NetworkAddress;
Expand Down Expand Up @@ -39,14 +40,24 @@

public class SslMultiPortTests extends SecurityIntegTestCase {

private static final int NUMBER_OF_CLIENT_PORTS = Constants.WINDOWS ? 300 : 100;

private static int randomClientPort;
private static String randomClientPortRange;
private static int randomNoClientAuthPort;
private static String randomNoClientAuthPortRange;
private static InetAddress localAddress;

@BeforeClass
public static void getRandomPort() {
randomClientPort = randomIntBetween(49000, 65500); // ephemeral port
randomNoClientAuthPort = randomIntBetween(49000, 65500);
randomClientPort = randomIntBetween(49152, 65535 - NUMBER_OF_CLIENT_PORTS);
randomClientPortRange = randomClientPort + "-" + (randomClientPort + NUMBER_OF_CLIENT_PORTS);

randomNoClientAuthPort = randomValueOtherThanMany(
port -> port >= randomClientPort - NUMBER_OF_CLIENT_PORTS && port <= randomClientPort + NUMBER_OF_CLIENT_PORTS,
() -> randomIntBetween(49152, 65535 - NUMBER_OF_CLIENT_PORTS)
);
randomNoClientAuthPortRange = randomNoClientAuthPort + "-" + (randomNoClientAuthPort + NUMBER_OF_CLIENT_PORTS);
localAddress = InetAddress.getLoopbackAddress();
}

Expand All @@ -60,9 +71,6 @@ public static void getRandomPort() {
*/
@Override
protected Settings nodeSettings(int nodeOrdinal, Settings otherSettings) {
String randomClientPortRange = randomClientPort + "-" + (randomClientPort + 100);
String randomNoClientAuthPortRange = randomNoClientAuthPort + "-" + (randomNoClientAuthPort + 100);

Path trustCert;
try {
trustCert = getDataPath("/org/elasticsearch/xpack/security/transport/ssl/certs/simple/testclient-client-profile.crt");
Expand Down