Fallback to working dir for native lib dir in tests #133422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When finding the platform dir to pass to jna we check for system properties which are either set by internal test gradle code or or the cli shell script. If neither of thse are set, we are in test code for an external plugin. This commit fixes the code to use the working dir in this fallback case. Previously we would have created a bogus path. Both are the same: external plugin tests can't load ES native libs since they don't have them available.
elasticsearchmachine
added
needs:triage
rjernst
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Note that this does not affect main because there we do not have JNA. The jdk loader directly loads the library when asked, but for JNA we have to set a special system property statically, which is what fails when trying to create the library path. |
|
Here's an example failure that occurs without this fix: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When finding the platform dir to pass to jna we check for system properties which are either set by internal test gradle code or or the cli shell script. If neither of thse are set, we are in test code for an external plugin. This commit fixes the code to use the working dir in this fallback case. Previously we would have created a bogus path. Both are the same: external plugin tests can't load ES native libs since they don't have them available.