Skip to content

Fallback to working dir for native lib dir in tests #133422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2025
Merged

Fallback to working dir for native lib dir in tests #133422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion libs/native/src/main/java/org/elasticsearch/nativeaccess/lib/LoaderHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,16 @@ private static Path findPlatformLibDir() {
return Paths.get(path);
}

Path homeDir = Paths.get(System.getProperty("es.path.home"));
String homeDirPath = System.getProperty("es.path.home");
if (homeDirPath == null) {
// if we don't have the native libs passed in for tests, and we don't have the home dir set
// then we must be in a test for an external plugin. there's nothing we can do to get the
// native libs, they don't exist, so just return the working dir, it will fail if the test
// actually tries to load a library
return Paths.get("");
}

Path homeDir = Paths.get(homeDirPath);
Path platformDir = homeDir.resolve("lib/platform");

String osname = System.getProperty("os.name");
Expand Down