Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installing multiple plugins as a transaction #50924

Merged
merged 3 commits into from Jan 14, 2020

Conversation

@jasontedor
Copy link
Member

jasontedor commented Jan 13, 2020

This commit allows the plugin installer to install multiple plugins in a single invocation. The installation will be treated as a transaction, so that all of the plugins are install successfully, or none of the plugins are installed.

Relates #50443

This commit allows the plugin installer to install multiple plugins in a
single invocation. The installation will be treated as a transaction, so
that all of the plugins are install successfully, or none of the plugins
are installed.
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

elasticmachine commented Jan 13, 2020

Pinging @elastic/es-core-infra (:Core/Infra/Plugins)

@jasontedor

This comment has been minimized.

Copy link
Member Author

jasontedor commented Jan 14, 2020

Thanks @rjernst. I have responded to your feedback.

@jasontedor

This comment has been minimized.

Copy link
Member Author

jasontedor commented Jan 14, 2020

@elasticmachine update branch

Copy link
Member

rjernst left a comment

LGTM. I still think we should output something as each plugin is installed so it is not a black box to the end, but that can always be changed later.

@jasontedor

This comment has been minimized.

Copy link
Member Author

jasontedor commented Jan 14, 2020

@elasticmachine run elasticsearch-ci/2

1 similar comment
@jasontedor

This comment has been minimized.

Copy link
Member Author

jasontedor commented Jan 14, 2020

@elasticmachine run elasticsearch-ci/2

@jasontedor jasontedor merged commit 6b20a2c into elastic:master Jan 14, 2020
10 checks passed
10 checks passed
CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docs Build finished.
Details
elasticsearch-ci/docs-check Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample-matrix-unix Build finished.
Details
elasticsearch-ci/packaging-sample-matrix-windows Build finished.
Details
jasontedor added a commit that referenced this pull request Jan 14, 2020
This commit allows the plugin installer to install multiple plugins in a
single invocation. The installation will be treated as a transaction, so
that all of the plugins are install successfully, or none of the plugins
are installed.
@jasontedor jasontedor deleted the jasontedor:multiple-plugins branch Jan 14, 2020
@jasontedor

This comment has been minimized.

Copy link
Member Author

jasontedor commented Jan 14, 2020

I still think we should output something as each plugin is installed so it is not a black box to the end, but that can always be changed later.

See #51001 and let me know what you think?

SivagurunathanV added a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
This commit allows the plugin installer to install multiple plugins in a
single invocation. The installation will be treated as a transaction, so
that all of the plugins are install successfully, or none of the plugins
are installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.