Use mappings versions instead of node versions in mappings upgrade service #99668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamrandolph
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
reviewed
Sep 20, 2023
server/src/main/java/org/elasticsearch/cluster/ClusterState.java
Outdated
Show resolved
Hide resolved
thecoop
approved these changes
Sep 20, 2023
williamrandolph
deleted the
sysindex/mappings-versions-in-mappings-upgrade-service
branch
williamrandolph
added a commit
to williamrandolph/elasticsearch
that referenced
this pull request
Nov 3, 2023
elastic#99668 seems to have introduced a bug where SystemIndexMappingUpdateService updates system index mappings even in mixed clusters. This PR restores the old version-based check in order to be sure that there's no update until the cluster is fully upgraded. Fixes elastic#99778, elastic#101331
williamrandolph
added a commit
that referenced
this pull request
Nov 3, 2023
* Don't update system index mappings in mixed clusters #99668 seems to have introduced a bug where SystemIndexMappingUpdateService updates system index mappings even in mixed clusters. This PR restores the old version-based check in order to be sure that there's no update until the cluster is fully upgraded. The timing of the mapping update seems to be causing worse problems, corrupting persisted cluster state. Fixes #99778, #101331 * Remove broken assertion The compatibility versions objects are not showing up correctly, so we shouldn't assert on them.
williamrandolph
added a commit
to williamrandolph/elasticsearch
that referenced
this pull request
Nov 3, 2023
* Don't update system index mappings in mixed clusters elastic#99668 seems to have introduced a bug where SystemIndexMappingUpdateService updates system index mappings even in mixed clusters. This PR restores the old version-based check in order to be sure that there's no update until the cluster is fully upgraded. The timing of the mapping update seems to be causing worse problems, corrupting persisted cluster state. Fixes elastic#99778, elastic#101331 * Remove broken assertion The compatibility versions objects are not showing up correctly, so we shouldn't assert on them.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 3, 2023
* Don't update system index mappings in mixed clusters #99668 seems to have introduced a bug where SystemIndexMappingUpdateService updates system index mappings even in mixed clusters. This PR restores the old version-based check in order to be sure that there's no update until the cluster is fully upgraded. The timing of the mapping update seems to be causing worse problems, corrupting persisted cluster state. Fixes #99778, #101331 * Remove broken assertion The compatibility versions objects are not showing up correctly, so we shouldn't assert on them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that cluster state has minimum system index mappings versions (#99307), the system index mappings upgrade service needs to use them to determine when to update mappings for system indices.
Closes #98504