Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Support custom filtering of buckets in geogrid aggregation visualizations #55520

Closed
talevy opened this issue Jan 22, 2020 · 7 comments · Fixed by #154983
Closed

[Maps] Support custom filtering of buckets in geogrid aggregation visualizations #55520

talevy opened this issue Jan 22, 2020 · 7 comments · Fixed by #154983
Assignees
Labels
enhancement New value added to drive a business result Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@talevy
Copy link
Contributor

talevy commented Jan 22, 2020

Describe the feature:

Enable a way for filtering buckets visualized in a map's
grid visualization.

This can potentially be implemented by
adding an additional bucket-selector pipeline aggregation to the ES query.

Describe a specific use case for the feature:

Sometimes it may be necessary to hide buckets in a map's
grid aggregation from showing buckets with a certain count.

elastic/elasticsearch#50480 describes a scenario where
it would be nice to have min_doc_count as
an additional parameter to a visualization so one can filter out
buckets that have a lower count than this.

@talevy talevy added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result labels Jan 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck
Copy link
Contributor

If I understand correctly, there are two possible asks:

  • just support filtering on min-count: min_doc_count is a "special" property, and can be applied to any bucket (now also geo_tile, which Maps is using for grid-sources). The Maps-UX could provide an option to set this param (similar to how in Visualize users can edit the "advanced json" and insert this filter there).
  • support any kind of filter: a more generic solution is to provide some UX for people to apply a custom bucket selector script. This is a more generic solution that could also be used to write a filter that's identical to setting min_doc_count: n.

@talevy
Copy link
Contributor Author

talevy commented Jan 22, 2020

support any kind of filter: a more generic solution is to provide some UX for people to apply a custom bucket selector script. This is a more generic solution that could also be used to write a filter that's identical to setting

correct, this second bullet point is the one I am suggesting as a way to implement this feature request.

@thomasneirynck
Copy link
Contributor

adding 7.16 label on this. cc @nreese . adding equivalent of min_doc_count to Maps metric-aggs would close functional gap with region/coordinate-map.

@thomasneirynck
Copy link
Contributor

wrt deprecations of old visualizations. This is a small gap, without a clear view of how many users would run into it. Can always pick up later if necessary, as we get feedback from users trying to upgrade.

@thomasneirynck
Copy link
Contributor

discussed offline. There's a narrow way of looking at: ie. supporting the equivalent functionality of setting the min_doc_count-param in the legacy tile_map and region_map visualizations. Closing this is what triggered adding the 7.16/8.0 labels.

The other one - supporting any bucket-filtering script - is broader, and out of scope.

Given that the narrow-case is niche, removing the target version-labels.

@jb1b84 jb1b84 added Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@jb1b84 jb1b84 removed the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Nov 3, 2022
@nreese nreese added loe:large Large Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Mar 9, 2023
nreese added a commit that referenced this issue Apr 22, 2023
Fixes #55520

PR adds ability to set mask configuration for metric fields to hide
features client side that are outside the range of the mask.

<img width="600" alt="Screen Shot 2023-04-19 at 3 45 15 PM"
src="https://user-images.githubusercontent.com/373691/233207269-854695dd-ea51-45cd-b092-3360092846bb.png">

<img width="600" alt="Screen Shot 2023-04-19 at 3 44 45 PM"
src="https://user-images.githubusercontent.com/373691/233207329-e0c7f20c-e789-446c-8994-87bcdf8e4bbe.png">

For vector layer, I could not use easier solution of filter expression
since filter expressions do not support feature-state. Instead,
implementation sets opacity paint property to 0.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants