Migrate elasticstack_kibana_action_connector resource to the plugin framework #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the elasticstack_kibana_action_connector resource from the SDKv2 to the Terraform plugin framework. The migration includes creating a new custom ConfigValue type to handle default values in connector configurations and enables explicit connector ID setting support.
Key changes include:
- Migration from SDKv2 to plugin framework implementation
- Introduction of custom ConfigValue type for handling connector configuration defaults
- Addition of UUID validation for connector IDs
- Framework diagnostics conversion utilities
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| provider/provider.go | Removed SDKv2 resource registration for kibana action connector |
| provider/plugin_framework.go | Added plugin framework resource registration |
| internal/kibana/connectors/*.go | New plugin framework implementation with custom config handling |
| internal/utils/validators/is_uuid.go | New UUID validator for connector IDs |
| internal/utils/diag.go | Added framework to SDK diagnostics conversion utility |
| internal/clients/kibana_oapi/connector.go | Updated to use framework diagnostics and simplified config defaults |
| internal/kibana/connector.go | Removed old SDKv2 implementation |
nick-benoit
reviewed
Sep 3, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* origin/main: Somehow I didn't merge this properly... (#1273) fix(deps): update module github.com/stretchr/testify to v1.11.1 (#1272) Migrate to terraform-plugin-testing (#1256) Migrate Elasticsearch enrich policy resource and data source to Terraform Plugin Framework (#1220) Add support for solution field in elasticsearch_kibana_space resource and data source (#1210) Don't force replacement when changing integration versions (#1255) chore(deps): update golang:1.25.0 docker digest to 5502b0e (#1267) chore(deps): update docker.elastic.co/kibana/kibana docker tag to v9.1.3 (#1263) Bump github.com/ulikunitz/xz from 0.5.12 to 0.5.14 (#1264)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin.
Migrates the old suppress diff functionality into a new ConfigValue type which ignores any default values added into the connector response.
Related to #1088
Related to #1214
Fixes #1228
Fixes #1066