Tdrz/ccoderefactoring #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use of the new frontend <-> backend data transfer mechanism because before the write was not buffered.
tdrz
commented
Oct 8, 2025
tdrz
commented
Oct 8, 2025
| } | ||
| } | ||
| } | ||
| resume_on_error: |
There was a problem hiding this comment.
Seems fine: resume_on_error was only jumped to if cma_rsize < 0 which is not the case with the new data transfer method.
tdrz
commented
Oct 8, 2025
|
|
||
| #if defined(__EMSCRIPTEN__) | ||
| EM_ASM( { | ||
| Module.is_worker = (typeof WorkerGlobalScope !== 'undefined') && self instanceof WorkerGlobalScope; |
There was a problem hiding this comment.
is is_worker used anywhere else?
tdrz
commented
Oct 8, 2025
| Module.is_worker = (typeof WorkerGlobalScope !== 'undefined') && self instanceof WorkerGlobalScope; | ||
| Module.FD_BUFFER_MAX = $0; Module.emscripten_copy_to = console.warn;} | ||
| , (CMA_MB * 1024 * 1024) / CMA_FD); /* ( global mem start / num fd max ) */ | ||
| Module.FD_BUFFER_MAX = $0; Module.emscripten_copy_to = console.warn;} // tdrz: what is FD_BUFFER_MAX? |
There was a problem hiding this comment.
emscripten_copy_to used anywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.