Added a “renderer.template” option #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2019
Closed
|
@develar can I do anything to get this merged in faster? I'd like to switch back from my fork of electron-webpack to the official version. |
|
Any update on this? This is a much needed feature! |
|
What's the hold up for merging this PR? |
|
WE NEED THIS! |
|
Also waiting for this. 👌🏻 |
|
Looks good to me! Thanks for the contribution, @fabiospampinato! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a template option:
So now the placement and extension of the template is configurable.
Also the way the custom js/css is added to the template is now general enough that it supports template too, so that we don't have to embed that custom js/css manually into the template.
This feature is pretty important for perceived performance, as I can now show my app's window as soon an possible and render a skeleton of the app rather than just waiting until it's fully loaded.