New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport (2-0-x) - docs: Document missing quit events during shutdown #13026

Merged
merged 2 commits into from May 21, 2018

Conversation

Projects
None yet
3 participants
@trop

trop bot commented May 21, 2018

Backport of #12986

See that PR for details.

@trop trop bot requested a review from electron/docs as a code owner May 21, 2018

@trop trop bot added the backport label May 21, 2018

@ckerr

ckerr approved these changes May 21, 2018

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere May 21, 2018

Member

i'll merge on

Member

codebytere commented May 21, 2018

i'll merge on

@codebytere codebytere merged commit 5acb7a0 into electron:2-0-x May 21, 2018

9 of 10 checks passed

ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment