New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Backport of #14648 (backport: 3-0-x) #15032

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
3 participants
@trop

trop bot commented Oct 9, 2018

Backport of #15025

See that PR for details.

Notes: Allows the window to be maximization status to be restored to previous value upon being resizable again.

@trop trop bot requested a review from electron/reviewers as a code owner Oct 9, 2018

@trop trop bot referenced this pull request Oct 9, 2018

Merged

fix: Backport of #14648 #15025

4 of 4 tasks complete

@trop trop bot added the backport label Oct 9, 2018

@ckerr

ckerr approved these changes Oct 9, 2018

@jkleinsc jkleinsc merged commit 8f743e6 into electron:3-0-x Oct 9, 2018

14 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Oct 9, 2018

Release Notes Persisted

Allows the window to be maximization status to be restored to previous value upon being resizable again.

release-clerk bot commented Oct 9, 2018

Release Notes Persisted

Allows the window to be maximization status to be restored to previous value upon being resizable again.

@ckerr ckerr referenced this pull request Oct 12, 2018

Open

3.0.x auto-generated release notes are difficult to read #15116

0 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment